Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/17235 )
Change subject: IMPALA-10609: Fix NPE in resolving table masks in StmtMetadataLoader ...................................................................... Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/17235/1//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/17235/1//COMMIT_MSG@7 PS1, Line 7: IMPALA-10609: Fix NPE in resolving table masks in StmtMetadataLoader > Is the null user ok for the GetColumns types operations because on the > catalog side we are not enforcing the table masking. i.e it is enforced only > for actual query planning. Yeah, they just get the metadata so won't trigger data masking. > The JIRA says NPE was seen in the log file. Did that not fail the unit test ? No, we catch any Exception thrown by collectPolicyTables(). So the NPE was catched and just logged. All the unit tests don't have subquery masking exprs or row filters, so they don't fail. > In RangerAuthorizationChecker.java, perhaps we should add Preconditions > checkNotNull for user in the relevant places. Sure. Done. -- To view, visit http://gerrit.cloudera.org:8080/17235 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I7aa20458b02e8a93a871b6dd875decfab82c4eae Gerrit-Change-Number: 17235 Gerrit-PatchSet: 2 Gerrit-Owner: Quanlong Huang <[email protected]> Gerrit-Reviewer: Aman Sinha <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Comment-Date: Sat, 27 Mar 2021 01:55:54 +0000 Gerrit-HasComments: Yes
