Aman Sinha has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/17230 )

Change subject: IMPALA-10554: Block updates when row-filter/column-mask is 
enabled for the user
......................................................................


Patch Set 5: Code-Review+2

> Patch Set 4:
> 
> (1 comment)
>
> Changes for the last PS: populate the column names to AuthorizableTable so we 
> can check all column masking policies of the table until we match a real mask 
> policy(i.e. not an unmask policy).

I would have thought that an unmask policy by definition would be skipped since 
it is not masking. Interesting find. Changes LGTM.


--
To view, visit http://gerrit.cloudera.org:8080/17230
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I1c899f2ec24b895867cbf2cf9ed23bc7b5a77326
Gerrit-Change-Number: 17230
Gerrit-PatchSet: 5
Gerrit-Owner: Quanlong Huang <[email protected]>
Gerrit-Reviewer: Aman Sinha <[email protected]>
Gerrit-Reviewer: Csaba Ringhofer <[email protected]>
Gerrit-Reviewer: Fang-Yu Rao <[email protected]>
Gerrit-Reviewer: Impala Public Jenkins <[email protected]>
Gerrit-Reviewer: Quanlong Huang <[email protected]>
Gerrit-Comment-Date: Tue, 30 Mar 2021 03:06:29 +0000
Gerrit-HasComments: No

Reply via email to