Andrew Sherman has posted comments on this change. ( http://gerrit.cloudera.org:8080/16819 )
Change subject: IMPALA-9910: [DOCS] update retry failed queries query option ...................................................................... Patch Set 2: (4 comments) Thanks, this is looking better http://gerrit.cloudera.org:8080/#/c/16819/2//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/16819/2//COMMIT_MSG@9 PS2, Line 9: added why cluster membership changes typically occur This seems to be about Patchset 2. The commit message should describe the whole change. Also please use sentences with capital letters and end with a period. http://gerrit.cloudera.org:8080/#/c/16819/2/docs/topics/impala_retry_failed_queries.xml File docs/topics/impala_retry_failed_queries.xml: http://gerrit.cloudera.org:8080/#/c/16819/2/docs/topics/impala_retry_failed_queries.xml@40 PS2, Line 40: blacklisted by the Impala Coordinator and if a SELECT query fails due to a cluster membership This is too complex. End the sentence with "Coordinator." and then start another with "If ..." http://gerrit.cloudera.org:8080/#/c/16819/2/docs/topics/impala_retry_failed_queries.xml@49 PS2, Line 49: <codeph>spool_all_results_for_retries</codeph>.</p> Should this say something like "set the spool_all_results_for_retries query option"? http://gerrit.cloudera.org:8080/#/c/16819/2/docs/topics/impala_retry_failed_queries.xml@53 PS2, Line 53: <codeph>ENABLED</codeph></p> If the type is BOOLEAN won't this be TRUE ? -- To view, visit http://gerrit.cloudera.org:8080/16819 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I3a65357a6e3d0bffa840b8636171a38bd9b22d17 Gerrit-Change-Number: 16819 Gerrit-PatchSet: 2 Gerrit-Owner: Shajini Thayasingh <[email protected]> Gerrit-Reviewer: Andrew Sherman <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Comment-Date: Wed, 31 Mar 2021 23:26:16 +0000 Gerrit-HasComments: Yes
