Hello Vihang Karajgaonkar, Gabor Kaszab, wangsheng, Impala Public Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/17248
to look at the new patch set (#2).
Change subject: IMPALA-10624: TestIcebergTable::test_alter_iceberg_tables
failed by stale file format
......................................................................
IMPALA-10624: TestIcebergTable::test_alter_iceberg_tables failed by stale file
format
During table creation we pushed all the table properties to the
Iceberg table, e.g. 'iceberg.file_format'. This works well with
current Iceberg version, but causes bugs with newer versions.
Newer versions of Iceberg refresh the HMS properties from the
table properties for every table update. That means if we
intially set a table property, we cannot modify it later because
Iceberg will rewrite it with the old value on every table update.
These table properties are not needed at the Iceberg table level,
so we can just skip passing them during table creation.
Testing:
* ran existing tests
* ran tests with newer version Iceberg
* checked manually that we don't set these properties at the Iceberg
table level
Change-Id: Iff8d5d1d90444aba11d47cfce522aaa45a4a74cc
---
M fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java
M fe/src/main/java/org/apache/impala/service/IcebergCatalogOpExecutor.java
2 files changed, 32 insertions(+), 4 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/48/17248/2
--
To view, visit http://gerrit.cloudera.org:8080/17248
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Iff8d5d1d90444aba11d47cfce522aaa45a4a74cc
Gerrit-Change-Number: 17248
Gerrit-PatchSet: 2
Gerrit-Owner: Zoltan Borok-Nagy <[email protected]>
Gerrit-Reviewer: Gabor Kaszab <[email protected]>
Gerrit-Reviewer: Impala Public Jenkins <[email protected]>
Gerrit-Reviewer: Vihang Karajgaonkar <[email protected]>
Gerrit-Reviewer: wangsheng <[email protected]>
