Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/17075 )
Change subject: IMPALA-10494: Making use of the min/max column stats to improve min/max filters ...................................................................... Patch Set 28: Code-Review+1 (1 comment) LGTM, but had a comment about testing Hudi tables http://gerrit.cloudera.org:8080/#/c/17075/28/testdata/workloads/functional-query/queries/QueryTest/compute-stats-column-minmax.test File testdata/workloads/functional-query/queries/QueryTest/compute-stats-column-minmax.test: http://gerrit.cloudera.org:8080/#/c/17075/28/testdata/workloads/functional-query/queries/QueryTest/compute-stats-column-minmax.test@98 PS28, Line 98: # Create a new hudi parquet table. Please note that it creates a plain Parquet table from the data in the Hudi table. Unfortunately Impala cannot write Hudi tables. I think we have the following options here: * Add a hudi table to the repo only for this test. But it needs some work to figure out how to do that * Use functional_parquet.hudi_non_partitioned and hope it doesn't break other tests. But we cannot guarantee it won't break future tests. * Create a Jira ticket to add Hudi testing later -- To view, visit http://gerrit.cloudera.org:8080/17075 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I08581b44419bb8da5940cbf98502132acd1c86df Gerrit-Change-Number: 17075 Gerrit-PatchSet: 28 Gerrit-Owner: Qifan Chen <[email protected]> Gerrit-Reviewer: Aman Sinha <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Qifan Chen <[email protected]> Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]> Gerrit-Comment-Date: Thu, 01 Apr 2021 11:57:22 +0000 Gerrit-HasComments: Yes
