[email protected] has posted comments on this change. ( http://gerrit.cloudera.org:8080/17276 )
Change subject: IMPALA-10637: Fixes bug in ValidWriteIdList comparison ...................................................................... Patch Set 3: (2 comments) Thanks for the review Csaba Ringhofer. I have addressed your comments. http://gerrit.cloudera.org:8080/#/c/17276/1//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/17276/1//COMMIT_MSG@9 PS1, Line 9: For a transactional table, catalogd compares previous and current ValidWriteList > nit: please wrap the commit message lines at 72 chars Sure http://gerrit.cloudera.org:8080/#/c/17276/1/fe/src/main/java/org/apache/impala/util/AcidUtils.java File fe/src/main/java/org/apache/impala/util/AcidUtils.java: http://gerrit.cloudera.org:8080/#/c/17276/1/fe/src/main/java/org/apache/impala/util/AcidUtils.java@752 PS1, Line 752: return Long.signum((a.getInvalidWriteIds()[minLen] - 1) - b.getHighWatermark()); > Note that Hive still uses the old version: Yes I have filed a jira in Hive as well https://issues.apache.org/jira/browse/HIVE-24975 -- To view, visit http://gerrit.cloudera.org:8080/17276 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Idaa4bcdbda1757a6451122efc505d1d483c879cc Gerrit-Change-Number: 17276 Gerrit-PatchSet: 3 Gerrit-Owner: Anonymous Coward <[email protected]> Gerrit-Reviewer: Aman Sinha <[email protected]> Gerrit-Reviewer: Anonymous Coward <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Vihang Karajgaonkar <[email protected]> Gerrit-Comment-Date: Tue, 06 Apr 2021 20:53:13 +0000 Gerrit-HasComments: Yes
