Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17298 )
Change subject: IMPALA-10648: Invalidate catalogd table cache for hms ddl apis which modify tables and partitions. ...................................................................... Patch Set 1: (51 comments) http://gerrit.cloudera.org:8080/#/c/17298/1/fe/src/main/java/org/apache/impala/catalog/metastore/MetastoreServiceHandler.java File fe/src/main/java/org/apache/impala/catalog/metastore/MetastoreServiceHandler.java: http://gerrit.cloudera.org:8080/#/c/17298/1/fe/src/main/java/org/apache/impala/catalog/metastore/MetastoreServiceHandler.java@348 PS1, Line 348: LOG.info("Invalidate catalogd cache for DDLs on non transactional tables is set to {}", line too long (91 > 90) http://gerrit.cloudera.org:8080/#/c/17298/1/fe/src/main/java/org/apache/impala/catalog/metastore/MetastoreServiceHandler.java@658 PS1, Line 658: removeNonTransactionalTableIfExists(dbname, tblname, "drop_table_with_environment_context"); line too long (98 > 90) http://gerrit.cloudera.org:8080/#/c/17298/1/fe/src/main/java/org/apache/impala/catalog/metastore/MetastoreServiceHandler.java@843 PS1, Line 843: invalidateNonTransactionalTableIfExists(newTable.getDbName(), newTable.getTableName(), line too long (92 > 90) http://gerrit.cloudera.org:8080/#/c/17298/1/fe/src/main/java/org/apache/impala/catalog/metastore/MetastoreServiceHandler.java@890 PS1, Line 890: Partition addedPartition = client.getHiveClient().getThriftClient().add_partition(partition); line too long (99 > 90) http://gerrit.cloudera.org:8080/#/c/17298/1/fe/src/main/java/org/apache/impala/catalog/metastore/MetastoreServiceHandler.java@891 PS1, Line 891: invalidateNonTransactionalTableIfExists(partition.getDbName(), partition.getTableName(), line too long (94 > 90) http://gerrit.cloudera.org:8080/#/c/17298/1/fe/src/main/java/org/apache/impala/catalog/metastore/MetastoreServiceHandler.java@904 PS1, Line 904: invalidateNonTransactionalTableIfExists(partition.getDbName(), partition.getTableName(), line too long (94 > 90) http://gerrit.cloudera.org:8080/#/c/17298/1/fe/src/main/java/org/apache/impala/catalog/metastore/MetastoreServiceHandler.java@914 PS1, Line 914: int numPartitionsAdded = client.getHiveClient().getThriftClient().add_partitions(partitionList); line too long (102 > 90) http://gerrit.cloudera.org:8080/#/c/17298/1/fe/src/main/java/org/apache/impala/catalog/metastore/MetastoreServiceHandler.java@916 PS1, Line 916: invalidateNonTransactionalTableIfExists(partition.getDbName(), partition.getTableName(), line too long (96 > 90) http://gerrit.cloudera.org:8080/#/c/17298/1/fe/src/main/java/org/apache/impala/catalog/metastore/MetastoreServiceHandler.java@930 PS1, Line 930: invalidateNonTransactionalTableIfExists(partitionSpec.getDbName(), partitionSpec.getTableName(), line too long (104 > 90) http://gerrit.cloudera.org:8080/#/c/17298/1/fe/src/main/java/org/apache/impala/catalog/metastore/MetastoreServiceHandler.java@955 PS1, Line 955: invalidateNonTransactionalTableIfExists(addPartitionsRequest.getDbName(), addPartitionsRequest.getTblName(), line too long (114 > 90) http://gerrit.cloudera.org:8080/#/c/17298/1/fe/src/main/java/org/apache/impala/catalog/metastore/MetastoreServiceHandler.java@968 PS1, Line 968: .append_partition_with_environment_context(dbname, tblname, partVals, environmentContext); line too long (104 > 90) http://gerrit.cloudera.org:8080/#/c/17298/1/fe/src/main/java/org/apache/impala/catalog/metastore/MetastoreServiceHandler.java@994 PS1, Line 994: .append_partition_by_name_with_environment_context(dbname, tblname, partName, line too long (91 > 90) http://gerrit.cloudera.org:8080/#/c/17298/1/fe/src/main/java/org/apache/impala/catalog/metastore/MetastoreServiceHandler.java@1021 PS1, Line 1021: .drop_partition_with_environment_context(dbname, tblname, partNames, deleteData, line too long (94 > 90) http://gerrit.cloudera.org:8080/#/c/17298/1/fe/src/main/java/org/apache/impala/catalog/metastore/MetastoreServiceHandler.java@1034 PS1, Line 1034: boolean partitionsDropped = client.getHiveClient().getThriftClient().drop_partition_by_name(dbname, line too long (106 > 90) http://gerrit.cloudera.org:8080/#/c/17298/1/fe/src/main/java/org/apache/impala/catalog/metastore/MetastoreServiceHandler.java@1049 PS1, Line 1049: .drop_partition_by_name_with_environment_context(dbName, tableName, partName, line too long (91 > 90) http://gerrit.cloudera.org:8080/#/c/17298/1/fe/src/main/java/org/apache/impala/catalog/metastore/MetastoreServiceHandler.java@1064 PS1, Line 1064: invalidateNonTransactionalTableIfExists(dropPartitionsRequest.getDbName(), dropPartitionsRequest.getTblName(), line too long (116 > 90) http://gerrit.cloudera.org:8080/#/c/17298/1/fe/src/main/java/org/apache/impala/catalog/metastore/MetastoreServiceHandler.java@1102 PS1, Line 1102: .exchange_partitions(partitionSpecs, sourceDb, sourceTable, destDb, destinationTableName); line too long (104 > 90) http://gerrit.cloudera.org:8080/#/c/17298/1/fe/src/main/java/org/apache/impala/catalog/metastore/MetastoreServiceHandler.java@1457 PS1, Line 1457: .alter_partitions_with_environment_context(dbName, tblName, list, environmentContext); line too long (100 > 90) http://gerrit.cloudera.org:8080/#/c/17298/1/fe/src/main/java/org/apache/impala/catalog/metastore/MetastoreServiceHandler.java@1458 PS1, Line 1458: invalidateNonTransactionalTableIfExists(dbName, tblName, "alter_partitions_with_environment_context"); line too long (108 > 90) http://gerrit.cloudera.org:8080/#/c/17298/1/fe/src/main/java/org/apache/impala/catalog/metastore/MetastoreServiceHandler.java@1483 PS1, Line 1483: invalidateNonTransactionalTableIfExists(dbName, tblName, "alter_partition_with_environment_context"); line too long (107 > 90) http://gerrit.cloudera.org:8080/#/c/17298/1/fe/src/main/java/org/apache/impala/catalog/metastore/MetastoreServiceHandler.java@2846 PS1, Line 2846: private void invalidateNonTransactionalTableIfExists(String dbNameWithCatalog, String tableName, String apiName) line too long (115 > 90) http://gerrit.cloudera.org:8080/#/c/17298/1/fe/src/main/java/org/apache/impala/catalog/metastore/MetastoreServiceHandler.java@2861 PS1, Line 2861: "when parsing dbName {} to invalidate/remove table from cache with error message: {}", line too long (108 > 90) http://gerrit.cloudera.org:8080/#/c/17298/1/fe/src/main/java/org/apache/impala/catalog/metastore/MetastoreServiceHandler.java@2867 PS1, Line 2867: LOG.debug("Not invalidating non transactional table {}.{} because db {} does not exist in catalogd cache", line too long (112 > 90) http://gerrit.cloudera.org:8080/#/c/17298/1/fe/src/main/java/org/apache/impala/catalog/metastore/MetastoreServiceHandler.java@2872 PS1, Line 2872: LOG.debug("Not invalidating non transactional table {}.{} because it does not exist in catalogd's db cache", line too long (114 > 90) http://gerrit.cloudera.org:8080/#/c/17298/1/fe/src/main/java/org/apache/impala/catalog/metastore/MetastoreServiceHandler.java@2881 PS1, Line 2881: LOG.debug("Table {} is transactional. Not removing it from catalogd cache", catalogTbl.getFullName()); line too long (108 > 90) http://gerrit.cloudera.org:8080/#/c/17298/1/fe/src/main/java/org/apache/impala/catalog/metastore/MetastoreServiceHandler.java@2890 PS1, Line 2890: LOG.info("Invalidated non transactional table {} from catalogd cache due to metastore api: {}", line too long (101 > 90) http://gerrit.cloudera.org:8080/#/c/17298/1/fe/src/main/java/org/apache/impala/catalog/metastore/MetastoreServiceHandler.java@2901 PS1, Line 2901: private void removeNonTransactionalTableIfExists(String dbNameWithCatalog, String tableName, String apiName) line too long (110 > 90) http://gerrit.cloudera.org:8080/#/c/17298/1/fe/src/main/java/org/apache/impala/catalog/metastore/MetastoreServiceHandler.java@2916 PS1, Line 2916: "when parsing dbName {} to invalidate/remove table from cache with error message: {}", line too long (108 > 90) http://gerrit.cloudera.org:8080/#/c/17298/1/fe/src/main/java/org/apache/impala/catalog/metastore/MetastoreServiceHandler.java@2927 PS1, Line 2927: LOG.debug("Not removing table {}.{} because it does not exist in catalogd's db cache", line too long (92 > 90) http://gerrit.cloudera.org:8080/#/c/17298/1/fe/src/main/java/org/apache/impala/catalog/metastore/MetastoreServiceHandler.java@2934 PS1, Line 2934: LOG.debug("Table {} is transactional. Not removing it from catalogd cache", catalogTbl.getFullName()); line too long (108 > 90) http://gerrit.cloudera.org:8080/#/c/17298/1/fe/src/main/java/org/apache/impala/catalog/metastore/MetastoreServiceHandler.java@2942 PS1, Line 2942: catalog_.removeTableIfExists(catalogTbl.getMetaStoreTable(), tableFound, tableMatched); line too long (99 > 90) http://gerrit.cloudera.org:8080/#/c/17298/1/fe/src/main/java/org/apache/impala/catalog/metastore/MetastoreServiceHandler.java@2944 PS1, Line 2944: LOG.info("Removed non transactional table {} from catalogd cache due to HMS api: {}", line too long (91 > 90) http://gerrit.cloudera.org:8080/#/c/17298/1/tests/custom_cluster/test_metastore_service.py File tests/custom_cluster/test_metastore_service.py: http://gerrit.cloudera.org:8080/#/c/17298/1/tests/custom_cluster/test_metastore_service.py@401 PS1, Line 401: flake8: E999 IndentationError: unexpected unindent http://gerrit.cloudera.org:8080/#/c/17298/1/tests/custom_cluster/test_metastore_service.py@433 PS1, Line 433: h flake8: E501 line too long (94 > 90 characters) http://gerrit.cloudera.org:8080/#/c/17298/1/tests/custom_cluster/test_metastore_service.py@436 PS1, Line 436: o flake8: E501 line too long (102 > 90 characters) http://gerrit.cloudera.org:8080/#/c/17298/1/tests/custom_cluster/test_metastore_service.py@437 PS1, Line 437: flake8: E501 line too long (95 > 90 characters) http://gerrit.cloudera.org:8080/#/c/17298/1/tests/custom_cluster/test_metastore_service.py@438 PS1, Line 438: c flake8: E501 line too long (95 > 90 characters) http://gerrit.cloudera.org:8080/#/c/17298/1/tests/custom_cluster/test_metastore_service.py@441 PS1, Line 441: c flake8: E501 line too long (93 > 90 characters) http://gerrit.cloudera.org:8080/#/c/17298/1/tests/custom_cluster/test_metastore_service.py@461 PS1, Line 461: a flake8: E501 line too long (112 > 90 characters) http://gerrit.cloudera.org:8080/#/c/17298/1/tests/custom_cluster/test_metastore_service.py@462 PS1, Line 462: a flake8: E501 line too long (112 > 90 characters) http://gerrit.cloudera.org:8080/#/c/17298/1/tests/custom_cluster/test_metastore_service.py@466 PS1, Line 466: e flake8: E501 line too long (92 > 90 characters) http://gerrit.cloudera.org:8080/#/c/17298/1/tests/custom_cluster/test_metastore_service.py@474 PS1, Line 474: , flake8: E501 line too long (95 > 90 characters) http://gerrit.cloudera.org:8080/#/c/17298/1/tests/custom_cluster/test_metastore_service.py@486 PS1, Line 486: flake8: E501 line too long (96 > 90 characters) http://gerrit.cloudera.org:8080/#/c/17298/1/tests/custom_cluster/test_metastore_service.py@489 PS1, Line 489: t flake8: E501 line too long (92 > 90 characters) http://gerrit.cloudera.org:8080/#/c/17298/1/tests/custom_cluster/test_metastore_service.py@512 PS1, Line 512: flake8: E501 line too long (96 > 90 characters) http://gerrit.cloudera.org:8080/#/c/17298/1/tests/custom_cluster/test_metastore_service.py@519 PS1, Line 519: e flake8: E501 line too long (100 > 90 characters) http://gerrit.cloudera.org:8080/#/c/17298/1/tests/custom_cluster/test_metastore_service.py@526 PS1, Line 526: q flake8: E501 line too long (96 > 90 characters) http://gerrit.cloudera.org:8080/#/c/17298/1/tests/custom_cluster/test_metastore_service.py@536 PS1, Line 536: flake8: E251 unexpected spaces around keyword / parameter equals http://gerrit.cloudera.org:8080/#/c/17298/1/tests/custom_cluster/test_metastore_service.py@536 PS1, Line 536: flake8: E251 unexpected spaces around keyword / parameter equals http://gerrit.cloudera.org:8080/#/c/17298/1/tests/custom_cluster/test_metastore_service.py@537 PS1, Line 537: flake8: E251 unexpected spaces around keyword / parameter equals http://gerrit.cloudera.org:8080/#/c/17298/1/tests/custom_cluster/test_metastore_service.py@537 PS1, Line 537: flake8: E251 unexpected spaces around keyword / parameter equals -- To view, visit http://gerrit.cloudera.org:8080/17298 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Idb9cc22ebfb51948433e4d57f4705ce201acaf98 Gerrit-Change-Number: 17298 Gerrit-PatchSet: 1 Gerrit-Owner: Sourabh Goyal <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Comment-Date: Fri, 09 Apr 2021 21:37:30 +0000 Gerrit-HasComments: Yes
