Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/17187 )
Change subject: IMPALA-10583: Fix bug on unbounded result spooling memory config. ...................................................................... IMPALA-10583: Fix bug on unbounded result spooling memory config. Two bugs happening on result spooling when we set two of its query options to 0 (unbounded). The first bug happens if max_spilled_result_spooling_mem = 0 (unbounded). max_unpinned_bytes_ in SpillableRowBatchQueue will be set to 0, SpillableRowBatchQueue::IsFull() then will always return true, and the query hang. This patch fix it by setting max_unpinned_bytes_ to INT64_MAX if max_spilled_result_spooling_mem = 0. The second bug happens if we set max_result_spooling_mem = 0 (unbounded). PlanRootSink.java will peg maxMemReservationBytes to always equal to minMemReservationBytes. This patch fixes this by reverting to the default max_result_spooling_mem (100MB). Testing: - Add test_unbounded_result_spooling_mem. - Pass core tests. Change-Id: If8f5e3668281bba8813f8082f45b4faa7721530e Reviewed-on: http://gerrit.cloudera.org:8080/17187 Reviewed-by: Impala Public Jenkins <[email protected]> Tested-by: Impala Public Jenkins <[email protected]> --- M be/src/exec/buffered-plan-root-sink.cc M be/src/runtime/spillable-row-batch-queue.cc M fe/src/main/java/org/apache/impala/planner/PlanRootSink.java M tests/query_test/test_result_spooling.py 4 files changed, 43 insertions(+), 6 deletions(-) Approvals: Impala Public Jenkins: Looks good to me, approved; Verified -- To view, visit http://gerrit.cloudera.org:8080/17187 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: If8f5e3668281bba8813f8082f45b4faa7721530e Gerrit-Change-Number: 17187 Gerrit-PatchSet: 3 Gerrit-Owner: Riza Suminto <[email protected]> Gerrit-Reviewer: Aman Sinha <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]>
