Csaba Ringhofer has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/17118 )

Change subject: IMPALA-10488: Add jwt-cpp 0.5.0 to the toolchain
......................................................................


Patch Set 3: Code-Review+2

>here are some CMake extensions that can go fetch a project as of a particular 
>revision and build it

I agree, that would be the best. It adds one more step that can fail, but if 
github doesn't work, then we wouldn't even get to that step.


--
To view, visit http://gerrit.cloudera.org:8080/17118
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: native-toolchain
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I77aa3b36b45e8ef3c2d7873327948197c2c65d11
Gerrit-Change-Number: 17118
Gerrit-PatchSet: 3
Gerrit-Owner: Joe McDonnell <joemcdonn...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <csringho...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <joemcdonn...@cloudera.com>
Gerrit-Comment-Date: Mon, 12 Apr 2021 10:17:14 +0000
Gerrit-HasComments: No

Reply via email to