Aman Sinha has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/17237 )
Change subject: IMPALA-10619: Minor refactoring of analytic function methods ...................................................................... IMPALA-10619: Minor refactoring of analytic function methods The FIRST_VALUE, LAST_VALUE functions go through standardization process in AnalyticExpr where they may be rewritten with different number of parameters or with different window frame. In order for an external FE to leverage this standardization, this patch creates a wrapper method for FunctionCallExpr creation and does minor refactoring. Also added accessor methods to AnalyticEvalNode and changed visibility of couple of methods in PlanNode for use by external FE. Testing: Ran PlannerTests. No new tests are added since this does not change the existing behavior. Change-Id: I39e4268c0c5500f09acf98357a80763c28f615c2 Reviewed-on: http://gerrit.cloudera.org:8080/17237 Reviewed-by: Impala Public Jenkins <[email protected]> Tested-by: Aman Sinha <[email protected]> Reviewed-by: Aman Sinha <[email protected]> --- M fe/src/main/java/org/apache/impala/analysis/AnalyticExpr.java M fe/src/main/java/org/apache/impala/planner/AnalyticEvalNode.java M fe/src/main/java/org/apache/impala/planner/PlanNode.java 3 files changed, 18 insertions(+), 7 deletions(-) Approvals: Impala Public Jenkins: Looks good to me, approved Aman Sinha: Looks good to me, approved; Verified -- To view, visit http://gerrit.cloudera.org:8080/17237 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: I39e4268c0c5500f09acf98357a80763c28f615c2 Gerrit-Change-Number: 17237 Gerrit-PatchSet: 5 Gerrit-Owner: Aman Sinha <[email protected]> Gerrit-Reviewer: Aman Sinha <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]>
