liuyao has posted comments on this change. ( http://gerrit.cloudera.org:8080/17299 )
Change subject: IMPALA-10652: Optimize the checking of the size of incremental stats ...................................................................... Patch Set 3: (2 comments) http://gerrit.cloudera.org:8080/#/c/17299/2/fe/src/main/java/org/apache/impala/analysis/ComputeStatsStmt.java File fe/src/main/java/org/apache/impala/analysis/ComputeStatsStmt.java: http://gerrit.cloudera.org:8080/#/c/17299/2/fe/src/main/java/org/apache/impala/analysis/ComputeStatsStmt.java@448 PS2, Line 448: numOfAllIncStats > May rename the variable to numOfAllIncStatsPartitions Done http://gerrit.cloudera.org:8080/#/c/17299/2/fe/src/main/java/org/apache/impala/analysis/ComputeStatsStmt.java@452 PS2, Line 452: if (partitionSet_ == null) { : numOfAllIncStatsPartitions = allPartitio > We may not need to verify the size limit when the partition set for increme It is a pre-check on the size of incremental stats to prevent the incremental stats from occupying too much memory after calculation. If no partition is specified, all partitions are calculated. Need to check whether the incremental stats of all partitions exceeds the threshold after calculation. -- To view, visit http://gerrit.cloudera.org:8080/17299 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I4f35ea936445015a3b8b8102b1891db29751b5ee Gerrit-Change-Number: 17299 Gerrit-PatchSet: 3 Gerrit-Owner: liuyao <[email protected]> Gerrit-Reviewer: Aman Sinha <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Qifan Chen <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-Reviewer: liuyao <[email protected]> Gerrit-Comment-Date: Wed, 14 Apr 2021 06:18:18 +0000 Gerrit-HasComments: Yes
