Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/17313 )
Change subject: IMPALA-10656: Fire insert events before commit ...................................................................... Patch Set 6: Code-Review+1 (4 comments) Looked at the backend, the change looks great! http://gerrit.cloudera.org:8080/#/c/17313/6//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/17313/6//COMMIT_MSG@17 PS6, Line 17: d, nit: some lines are longer than 72 chars http://gerrit.cloudera.org:8080/#/c/17313/6/be/src/exec/hdfs-table-sink.cc File be/src/exec/hdfs-table-sink.cc: http://gerrit.cloudera.org:8080/#/c/17313/6/be/src/exec/hdfs-table-sink.cc@484 PS6, Line 484: current_file +1 for the rename :) http://gerrit.cloudera.org:8080/#/c/17313/6/be/src/runtime/dml-exec-state.h File be/src/runtime/dml-exec-state.h: http://gerrit.cloudera.org:8080/#/c/17313/6/be/src/runtime/dml-exec-state.h@63 PS6, Line 63: staging_dir_to_clean_up nit: could you please mention this parameter in the comment? http://gerrit.cloudera.org:8080/#/c/17313/6/be/src/runtime/dml-exec-state.cc File be/src/runtime/dml-exec-state.cc: http://gerrit.cloudera.org:8080/#/c/17313/6/be/src/runtime/dml-exec-state.cc@496 PS6, Line 496: } nit: add extra line -- To view, visit http://gerrit.cloudera.org:8080/17313 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I2ed812dbcb5f55efff3a910a3daeeb76cd3295b9 Gerrit-Change-Number: 17313 Gerrit-PatchSet: 6 Gerrit-Owner: Csaba Ringhofer <csringho...@cloudera.com> Gerrit-Reviewer: Csaba Ringhofer <csringho...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Vihang Karajgaonkar <vih...@cloudera.com> Gerrit-Reviewer: Zoltan Borok-Nagy <borokna...@cloudera.com> Gerrit-Comment-Date: Wed, 14 Apr 2021 16:12:40 +0000 Gerrit-HasComments: Yes
