Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/17303 )
Change subject: IMPALA-10654: Fix precision loss in DecimalValue to double conversion. ...................................................................... Patch Set 5: (4 comments) The change looks great. A test with Parquet would be nice, other than that I only found nitpicks. When you upload a new PS please reply to the comments. Most of the time clicking on "Done" is enough. This way we'll know we won't left anything open. http://gerrit.cloudera.org:8080/#/c/17303/5/be/src/runtime/decimal-value.inline.h File be/src/runtime/decimal-value.inline.h: http://gerrit.cloudera.org:8080/#/c/17303/5/be/src/runtime/decimal-value.inline.h@753 PS5, Line 753: ( nit: parentheses not needed http://gerrit.cloudera.org:8080/#/c/17303/5/be/src/runtime/decimal-value.inline.h@754 PS5, Line 754: nit: we indent with 4 spaces if the line belongs to the same statement as the previous line. http://gerrit.cloudera.org:8080/#/c/17303/5/be/src/runtime/decimal-value.inline.h@755 PS5, Line 755: is_negative, &success nit: I think we should either put each argument to a separate line, or put all of them to the previous line. In this case I think the latter makes more sense. http://gerrit.cloudera.org:8080/#/c/17303/5/testdata/workloads/functional-query/queries/QueryTest/values.test File testdata/workloads/functional-query/queries/QueryTest/values.test: http://gerrit.cloudera.org:8080/#/c/17303/5/testdata/workloads/functional-query/queries/QueryTest/values.test@104 PS5, Line 104: For write path, the default precision of 16 is a limitation yet to be That's true for text tables, but could you please add a test with a Parquet table? I think we should getter better precision there. -- To view, visit http://gerrit.cloudera.org:8080/17303 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I56f0652cb8f81a491b87d9b108a94c00ae6c99a1 Gerrit-Change-Number: 17303 Gerrit-PatchSet: 5 Gerrit-Owner: Amogh Margoor <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]> Gerrit-Comment-Date: Wed, 14 Apr 2021 16:31:32 +0000 Gerrit-HasComments: Yes
