Vihang Karajgaonkar has posted comments on this change. ( http://gerrit.cloudera.org:8080/17284 )
Change subject: IMPALA-10645: Log catalogd HMS API metrics ...................................................................... Patch Set 2: (5 comments) http://gerrit.cloudera.org:8080/#/c/17284/2/common/thrift/JniCatalog.thrift File common/thrift/JniCatalog.thrift: http://gerrit.cloudera.org:8080/#/c/17284/2/common/thrift/JniCatalog.thrift@849 PS2, Line 849: > nit: redundant blank line Done http://gerrit.cloudera.org:8080/#/c/17284/2/common/thrift/JniCatalog.thrift@884 PS2, Line 884: > nit: redundant blank line Done http://gerrit.cloudera.org:8080/#/c/17284/2/common/thrift/JniCatalog.thrift@909 PS2, Line 909: > nit: redundant blank line Done http://gerrit.cloudera.org:8080/#/c/17284/2/common/thrift/JniCatalog.thrift@934 PS2, Line 934: > nit: redundant blank lines Done http://gerrit.cloudera.org:8080/#/c/17284/2/fe/src/main/java/org/apache/impala/catalog/metastore/HmsApiNameEnum.java File fe/src/main/java/org/apache/impala/catalog/metastore/HmsApiNameEnum.java: http://gerrit.cloudera.org:8080/#/c/17284/2/fe/src/main/java/org/apache/impala/catalog/metastore/HmsApiNameEnum.java@23 PS2, Line 23: * > nit: remove this line Done -- To view, visit http://gerrit.cloudera.org:8080/17284 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Id41afe89bbe3395c158919bddd09f302c6752287 Gerrit-Change-Number: 17284 Gerrit-PatchSet: 2 Gerrit-Owner: Vihang Karajgaonkar <vih...@cloudera.com> Gerrit-Reviewer: Aman Sinha <amsi...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Quanlong Huang <huangquanl...@gmail.com> Gerrit-Reviewer: Vihang Karajgaonkar <vih...@cloudera.com> Gerrit-Comment-Date: Wed, 14 Apr 2021 22:01:05 +0000 Gerrit-HasComments: Yes
