Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/17195 )
Change subject: IMPALA-10584: Defer advancing read page if stream only has 2 pages. ...................................................................... Patch Set 6: Code-Review+1 > > Patch set 5 change the condition on when to NOT advance the read page. > > Read page will not be advanced in UnpinStream if read page is attached to > > output RowBatch and there are only 2 pages in the stream. > > Sorry, I should mention patch set 6 instead of 5. Nice! I think this fix is more clean and safe. LGTM. Give +1 first in case other guys are also reviewing this. -- To view, visit http://gerrit.cloudera.org:8080/17195 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I16137b6e423f190f60c3115a06ccd0f77e9f585a Gerrit-Change-Number: 17195 Gerrit-PatchSet: 6 Gerrit-Owner: Riza Suminto <[email protected]> Gerrit-Reviewer: Bikramjeet Vig <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Qifan Chen <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Comment-Date: Mon, 19 Apr 2021 02:11:45 +0000 Gerrit-HasComments: No
