Attila Jeges has posted comments on this change. ( http://gerrit.cloudera.org:8080/17325 )
Change subject: IMPALA-10662: Change EE tests to return the same results for HS2 as Beeswax ...................................................................... Patch Set 3: (1 comment) http://gerrit.cloudera.org:8080/#/c/17325/3/tests/common/impala_connection.py File tests/common/impala_connection.py: http://gerrit.cloudera.org:8080/#/c/17325/3/tests/common/impala_connection.py@301 PS3, Line 301: convert_types=False According to the impyla comments: convert_types : bool, optional When `False`, timestamps and decimal values will not be converted to Python `datetime` and `Decimal` values. (These conversions are expensive.) Only applies when using HS2 protocol versions > 6. The comment mentions DECIMAL and TIMESTAMP values but it doesn't mention FLOAT & DOUBLE values. I'm just curious, why were FLOAT/DOUBLE values previously converted to a lower precision value? -- To view, visit http://gerrit.cloudera.org:8080/17325 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: If69ae90c6333ff245c2b951af5689e3071f85cb2 Gerrit-Change-Number: 17325 Gerrit-PatchSet: 3 Gerrit-Owner: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Attila Jeges <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Tamas Mate <[email protected]> Gerrit-Comment-Date: Tue, 20 Apr 2021 16:18:47 +0000 Gerrit-HasComments: Yes
