Aman Sinha has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/17312 )

Change subject: IMPALA-10655: Add ImpalaServer interface to Initialize 
TQueryCtx for external frontends
......................................................................


Patch Set 2:

(2 comments)

http://gerrit.cloudera.org:8080/#/c/17312/2/common/thrift/ImpalaService.thrift
File common/thrift/ImpalaService.thrift:

http://gerrit.cloudera.org:8080/#/c/17312/2/common/thrift/ImpalaService.thrift@877
PS2, Line 877:   TInitQueryContextResp InitQueryContext();
nit: pls add a comment


http://gerrit.cloudera.org:8080/#/c/17312/2/tests/run-tests.py
File tests/run-tests.py:

http://gerrit.cloudera.org:8080/#/c/17312/2/tests/run-tests.py@41
PS2, Line 41:                    'feng_tests', 'test-hive-udfs', 'external-fe']
Can you double check on this list of additional directories ? I believe the 
first one is not needed.



--
To view, visit http://gerrit.cloudera.org:8080/17312
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I59cebcf087e703a4ab49fb44f6f5ba1044f26546
Gerrit-Change-Number: 17312
Gerrit-PatchSet: 2
Gerrit-Owner: Kurt Deschler <[email protected]>
Gerrit-Reviewer: Aman Sinha <[email protected]>
Gerrit-Reviewer: Impala Public Jenkins <[email protected]>
Gerrit-Reviewer: Joe McDonnell <[email protected]>
Gerrit-Reviewer: Kurt Deschler <[email protected]>
Gerrit-Comment-Date: Tue, 20 Apr 2021 16:34:50 +0000
Gerrit-HasComments: Yes

Reply via email to