Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17332 )
Change subject: IMPALA-9155: Add recovery mechanism to admission service ...................................................................... Patch Set 1: (7 comments) http://gerrit.cloudera.org:8080/#/c/17332/1/be/src/scheduling/admission-controller.cc File be/src/scheduling/admission-controller.cc: http://gerrit.cloudera.org:8080/#/c/17332/1/be/src/scheduling/admission-controller.cc@2103 PS1, Line 2103: DCHECK(num_backends_to_release_.find(state->query_id()) == num_backends_to_release_.end()); line too long (93 > 90) http://gerrit.cloudera.org:8080/#/c/17332/1/be/src/scheduling/admission-controller.cc@2104 PS1, Line 2104: num_backends_to_release_[state->query_id()] = state->per_backend_schedule_states().size(); line too long (92 > 90) http://gerrit.cloudera.org:8080/#/c/17332/1/tests/custom_cluster/test_admission_controller.py File tests/custom_cluster/test_admission_controller.py: http://gerrit.cloudera.org:8080/#/c/17332/1/tests/custom_cluster/test_admission_controller.py@1578 PS1, Line 1578: : flake8: E231 missing whitespace after ':' http://gerrit.cloudera.org:8080/#/c/17332/1/tests/custom_cluster/test_admission_controller.py@1585 PS1, Line 1585: - flake8: E226 missing whitespace around arithmetic operator http://gerrit.cloudera.org:8080/#/c/17332/1/tests/custom_cluster/test_admission_controller.py@1589 PS1, Line 1589: / flake8: E226 missing whitespace around arithmetic operator http://gerrit.cloudera.org:8080/#/c/17332/1/tests/custom_cluster/test_admission_controller.py@1614 PS1, Line 1614: 2 flake8: E501 line too long (99 > 90 characters) http://gerrit.cloudera.org:8080/#/c/17332/1/tests/custom_cluster/test_admission_controller.py@1626 PS1, Line 1626: k flake8: E501 line too long (97 > 90 characters) -- To view, visit http://gerrit.cloudera.org:8080/17332 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I8ad3ef9b9e2496c484833d6326ce914c851e02fd Gerrit-Change-Number: 17332 Gerrit-PatchSet: 1 Gerrit-Owner: Bikramjeet Vig <[email protected]> Gerrit-Reviewer: Andrew Sherman <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Comment-Date: Thu, 22 Apr 2021 10:40:12 +0000 Gerrit-HasComments: Yes
