Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/17170 )
Change subject: IMPALA-7825: Upgrade Thrift version to 0.11.0 ...................................................................... Patch Set 20: (5 comments) PS16 adds a few more unicode related fix (this time to printing errors from Impala) http://gerrit.cloudera.org:8080/#/c/17170/16/bin/impala-shell.sh File bin/impala-shell.sh: http://gerrit.cloudera.org:8080/#/c/17170/16/bin/impala-shell.sh@30 PS16, Line 30: > This dir no longer exists, which causes the data-loading failure that impal Thanks a lot for spotting this! http://gerrit.cloudera.org:8080/#/c/17170/16/shell/impala_client.py File shell/impala_client.py: http://gerrit.cloudera.org:8080/#/c/17170/16/shell/impala_client.py@1149 PS16, Line 1149: ry_handle, False > nit: isinstance(row, str) Done http://gerrit.cloudera.org:8080/#/c/17170/16/shell/impala_shell.py File shell/impala_shell.py: http://gerrit.cloudera.org:8080/#/c/17170/16/shell/impala_shell.py@1143 PS16, Line 1143: > nit: isinstance(col, str) Done http://gerrit.cloudera.org:8080/#/c/17170/16/shell/shell_output.py File shell/shell_output.py: http://gerrit.cloudera.org:8080/#/c/17170/16/shell/shell_output.py@44 PS16, Line 44: isinstance(entry, > nit: isinstance(entry, str) Done http://gerrit.cloudera.org:8080/#/c/17170/16/shell/shell_output.py@90 PS16, Line 90: isinstance(val, unic > nit: isinstance(val, unicode) Done -- To view, visit http://gerrit.cloudera.org:8080/17170 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Idd13f177b4f7acc07872ea6399035aa180ef6ab6 Gerrit-Change-Number: 17170 Gerrit-PatchSet: 20 Gerrit-Owner: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Qifan Chen <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Reviewer: Tamas Mate <[email protected]> Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]> Gerrit-Comment-Date: Fri, 23 Apr 2021 18:11:17 +0000 Gerrit-HasComments: Yes
