Amogh Margoor has posted comments on this change. ( http://gerrit.cloudera.org:8080/17348 )
Change subject: IMPALA-10471: Making deadline for Shutdown by SIGRTMIN configurable ...................................................................... Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/17348/2/tests/custom_cluster/test_restart_services.py File tests/custom_cluster/test_restart_services.py: http://gerrit.cloudera.org:8080/#/c/17348/2/tests/custom_cluster/test_restart_services.py@603 PS2, Line 603: > nit: indentation Thanks Tamas for the review. Just for my clarification, as self.EXEC_SHUTDOWN_DEADLINE_S is an argument of `format` function and not that of `assert_impalad_log_contains`, shouldn't it be at 2 spaces after arguments of `assert_impalad_log_contains` start ? -- To view, visit http://gerrit.cloudera.org:8080/17348 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I52cb1ba76e7ce9de86ceb2f84389b1ab257e4c05 Gerrit-Change-Number: 17348 Gerrit-PatchSet: 2 Gerrit-Owner: Amogh Margoor <[email protected]> Gerrit-Reviewer: Amogh Margoor <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Tamas Mate <[email protected]> Gerrit-Comment-Date: Wed, 28 Apr 2021 10:30:41 +0000 Gerrit-HasComments: Yes
