Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/17374 )
Change subject: IMPALA-10691: Fix multithreading related crash in CAST FORMAT ...................................................................... IMPALA-10691: Fix multithreading related crash in CAST FORMAT The issue occurs when a CastFormatExpr is shared among threads and multiple threads call its OpenEvaluator(). Later calls delete the DateTimeFormatContext created by older calls which makes fn_ctx->GetFunctionState() a dangling pointer. This only happens when CastFormatExpr is shared among FragmentInstances - in case of scanner threads OpenEvaluator() is called with THREAD_LOCAL and returns early without modifying anything. Testing: - added a regression test Change-Id: I501c8a184591b1c836b2ca4cada1f2117f9f5c99 Reviewed-on: http://gerrit.cloudera.org:8080/17374 Reviewed-by: Impala Public Jenkins <[email protected]> Tested-by: Impala Public Jenkins <[email protected]> --- M be/src/exprs/cast-format-expr.cc M be/src/exprs/cast-format-expr.h M testdata/workloads/functional-query/queries/QueryTest/cast_format_from_table.test 3 files changed, 23 insertions(+), 9 deletions(-) Approvals: Impala Public Jenkins: Looks good to me, approved; Verified -- To view, visit http://gerrit.cloudera.org:8080/17374 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: I501c8a184591b1c836b2ca4cada1f2117f9f5c99 Gerrit-Change-Number: 17374 Gerrit-PatchSet: 5 Gerrit-Owner: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Gabor Kaszab <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]>
