Tamas Mate has posted comments on this change. ( http://gerrit.cloudera.org:8080/17347 )
Change subject: IMPALA-9967: Add support for reading ORC's TIMESTAMP WITH LOCAL TIMEZONE ...................................................................... Patch Set 1: (1 comment) Hi Zoltan, looks good to me, just left an observation on the test. http://gerrit.cloudera.org:8080/#/c/17347/1/testdata/workloads/functional-query/queries/QueryTest/create-table-like-file-orc.test File testdata/workloads/functional-query/queries/QueryTest/create-table-like-file-orc.test: http://gerrit.cloudera.org:8080/#/c/17347/1/testdata/workloads/functional-query/queries/QueryTest/create-table-like-file-orc.test@132 PS1, Line 132: QUERY I think could be a CREATE section, then the RESULTS section would not be needed here. -- To view, visit http://gerrit.cloudera.org:8080/17347 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Icb0c6a43ebea21f1cba5b8f304db7c4bd43967d9 Gerrit-Change-Number: 17347 Gerrit-PatchSet: 1 Gerrit-Owner: Zoltan Borok-Nagy <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Tamas Mate <[email protected]> Gerrit-Reviewer: wangsheng <[email protected]> Gerrit-Comment-Date: Mon, 03 May 2021 07:48:32 +0000 Gerrit-HasComments: Yes
