Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/17380 )
Change subject: IMPALA-10692: Fix acid insert when event polling is enabled ...................................................................... Patch Set 2: Code-Review+2 (3 comments) The change looks good to me. I have couple of questions though. http://gerrit.cloudera.org:8080/#/c/17380/2//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/17380/2//COMMIT_MSG@24 PS2, Line 24: ACID inserts from Hive work differently, they always cause an : ALTER_TABLE or ALTER_PARTITION Shouldn't Impala behave the same? http://gerrit.cloudera.org:8080/#/c/17380/2//COMMIT_MSG@29 PS2, Line 29: (before the commit is finished). So if the following happens: 1. Hive sends ALTER* events during an INSERT 2. Impala reloads table metadata 3. Hive commits transaction then Impala only adds the new partitions to the Catalog table, but won't see the new data as it is not yet observable at point 2? Shouldn't Impala listen to the COMMIT event and refresh the table? http://gerrit.cloudera.org:8080/#/c/17380/2/tests/custom_cluster/test_event_processing.py File tests/custom_cluster/test_event_processing.py: http://gerrit.cloudera.org:8080/#/c/17380/2/tests/custom_cluster/test_event_processing.py@534 PS2, Line 534: overwrites "writes to"? -- To view, visit http://gerrit.cloudera.org:8080/17380 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I8c2d0702232538a746410539ad55f87b7fde57e7 Gerrit-Change-Number: 17380 Gerrit-PatchSet: 2 Gerrit-Owner: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Vihang Karajgaonkar <[email protected]> Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]> Gerrit-Comment-Date: Mon, 03 May 2021 14:52:07 +0000 Gerrit-HasComments: Yes
