Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/17323 )
Change subject: Upgrading Python crptography library ...................................................................... Patch Set 2: Code-Review+1 (2 comments) http://gerrit.cloudera.org:8080/#/c/17323/2//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/17323/2//COMMIT_MSG@7 PS2, Line 7: crptography typo, missing first y http://gerrit.cloudera.org:8080/#/c/17323/2/infra/python/deps/adls-requirements.txt File infra/python/deps/adls-requirements.txt: http://gerrit.cloudera.org:8080/#/c/17323/2/infra/python/deps/adls-requirements.txt@24 PS2, Line 24: cryptography==3.2 about testing: this change only affects ADLS environments, which is not covered in GVO. It would be great to run the tests in ADLS environment to ensure that nothing breaks. (there are several breaking changes in the change list) Note that these libraries are only used in the test environment, not in Impala itself, so the change cannot break a development environment, -- To view, visit http://gerrit.cloudera.org:8080/17323 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I1d35b73dc245781aa36282c6a268390152b63f05 Gerrit-Change-Number: 17323 Gerrit-PatchSet: 2 Gerrit-Owner: Jim Apple <jbap...@apache.org> Gerrit-Reviewer: Csaba Ringhofer <csringho...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Jim Apple <jbap...@apache.org> Gerrit-Reviewer: Joe McDonnell <joemcdonn...@cloudera.com> Gerrit-Comment-Date: Mon, 10 May 2021 15:01:35 +0000 Gerrit-HasComments: Yes