Impala Public Jenkins has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/17351 )

Change subject: POC: use puresasl instead of sasl in impala-shell
......................................................................


Patch Set 8:

(9 comments)

http://gerrit.cloudera.org:8080/#/c/17351/8/bin/run-workload.py
File bin/run-workload.py:

http://gerrit.cloudera.org:8080/#/c/17351/8/bin/run-workload.py@223
PS8, Line 223: i
flake8: F401 'puresasl' imported but unused


http://gerrit.cloudera.org:8080/#/c/17351/8/shell/impala_sasl_compat.py
File shell/impala_sasl_compat.py:

http://gerrit.cloudera.org:8080/#/c/17351/8/shell/impala_sasl_compat.py@18
PS8, Line 18: e
flake8: E501 line too long (116 > 90 characters)


http://gerrit.cloudera.org:8080/#/c/17351/8/shell/impala_sasl_compat.py@23
PS8, Line 23: @contextmanager
flake8: E302 expected 2 blank lines, found 1


http://gerrit.cloudera.org:8080/#/c/17351/8/shell/impala_sasl_compat.py@24
PS8, Line 24:
flake8: E251 unexpected spaces around keyword / parameter equals


http://gerrit.cloudera.org:8080/#/c/17351/8/shell/impala_sasl_compat.py@24
PS8, Line 24:
flake8: E251 unexpected spaces around keyword / parameter equals


http://gerrit.cloudera.org:8080/#/c/17351/8/tests/util/impala_sasl_compat.py
File tests/util/impala_sasl_compat.py:

http://gerrit.cloudera.org:8080/#/c/17351/8/tests/util/impala_sasl_compat.py@18
PS8, Line 18: e
flake8: E501 line too long (116 > 90 characters)


http://gerrit.cloudera.org:8080/#/c/17351/8/tests/util/impala_sasl_compat.py@23
PS8, Line 23: @contextmanager
flake8: E302 expected 2 blank lines, found 1


http://gerrit.cloudera.org:8080/#/c/17351/8/tests/util/impala_sasl_compat.py@24
PS8, Line 24:
flake8: E251 unexpected spaces around keyword / parameter equals


http://gerrit.cloudera.org:8080/#/c/17351/8/tests/util/impala_sasl_compat.py@24
PS8, Line 24:
flake8: E251 unexpected spaces around keyword / parameter equals



--
To view, visit http://gerrit.cloudera.org:8080/17351
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iba5a15e867969938792d120cd8f1ad1ed6370906
Gerrit-Change-Number: 17351
Gerrit-PatchSet: 8
Gerrit-Owner: Csaba Ringhofer <[email protected]>
Gerrit-Reviewer: Attila Jeges <[email protected]>
Gerrit-Reviewer: Impala Public Jenkins <[email protected]>
Gerrit-Comment-Date: Sat, 15 May 2021 07:37:30 +0000
Gerrit-HasComments: Yes

Reply via email to