Andrew Sherman has posted comments on this change. ( http://gerrit.cloudera.org:8080/17455 )
Change subject: IMPALA-10695:add OSS/JindoFS support, create a dedicate thread pool for this kind of target, default is 16. ...................................................................... Patch Set 4: (1 comment) Please take a look at other Impala commit messages to see examples of how to do this. Note I also cleared the 'topic' you set in gerrit as it seemed to make the main gerrit page untidy. http://gerrit.cloudera.org:8080/#/c/17455/4//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/17455/4//COMMIT_MSG@7 PS4, Line 7: IMPALA-10695:add OSS/JindoFS support, create a dedicate thread pool for this kind of target, default is 16. I think you should have a simple first line like "IMPALA-10695: add dedicated thread pool for OSS/JindoFS." Then, after a blank line a description of what is in the change: - a sentence describing OSS/JindoFS. - a link to more information about OSS/JindoFS. - why the change is useful - how you tested the change -- To view, visit http://gerrit.cloudera.org:8080/17455 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I4643105628f3860e3145c85d9ed205fe20291add Gerrit-Change-Number: 17455 Gerrit-PatchSet: 4 Gerrit-Owner: Yong Yang <yong.su...@163.com> Gerrit-Reviewer: Andrew Sherman <asher...@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Yong Yang <yong.su...@163.com> Gerrit-Comment-Date: Mon, 17 May 2021 16:53:17 +0000 Gerrit-HasComments: Yes
