Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/17465 )
Change subject: IMPALA-10704: Fix retried query id not being unregistered when retry fails ...................................................................... Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/17465/1/be/src/runtime/query-driver.h File be/src/runtime/query-driver.h: http://gerrit.cloudera.org:8080/#/c/17465/1/be/src/runtime/query-driver.h@265 PS1, Line 265: registered_retry_query_id_ > Should we set the initial value zero for this variable explicitly? I think we don't need this because the default constructor of TUniqueId already does it: be/generated-sources/gen-cpp/Types_types.h class TUniqueId { public: TUniqueId(const TUniqueId&); TUniqueId(TUniqueId&&); TUniqueId& operator=(const TUniqueId&); TUniqueId& operator=(TUniqueId&&); TUniqueId() : hi(0), lo(0) { // <----------- The default is setting hi and lo to 0 } }; -- To view, visit http://gerrit.cloudera.org:8080/17465 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I074526799d68041a425b2379e74f8d8b45ce892a Gerrit-Change-Number: 17465 Gerrit-PatchSet: 1 Gerrit-Owner: Quanlong Huang <huangquanl...@gmail.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Quanlong Huang <huangquanl...@gmail.com> Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com> Gerrit-Reviewer: Xianqing He <hexianqing...@126.com> Gerrit-Comment-Date: Tue, 18 May 2021 01:02:07 +0000 Gerrit-HasComments: Yes
