Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/17469 )
Change subject: IMPALA-9770: [DOCS] Remove Sentry references in documentation ...................................................................... Patch Set 1: (10 comments) http://gerrit.cloudera.org:8080/#/c/17469/1/docs/shared/impala_common.xml File docs/shared/impala_common.xml: http://gerrit.cloudera.org:8080/#/c/17469/1/docs/shared/impala_common.xml@4579 PS1, Line 4579: <li> Impala now does not support privileges of <codeph>DELETE</codeph>, : <codeph>UPDATE</codeph>, and <codeph>UPSERT</codeph> operations. </li> I'm thinking this sentence is already covered in the sentence just above it. http://gerrit.cloudera.org:8080/#/c/17469/1/docs/topics/impala_alter_database.xml File docs/topics/impala_alter_database.xml: http://gerrit.cloudera.org:8080/#/c/17469/1/docs/topics/impala_alter_database.xml@a68 PS1, Line 68: I think we still support this variant. Fang-Yu, can you confirm? http://gerrit.cloudera.org:8080/#/c/17469/1/docs/topics/impala_alter_table.xml File docs/topics/impala_alter_table.xml: http://gerrit.cloudera.org:8080/#/c/17469/1/docs/topics/impala_alter_table.xml@a74 PS1, Line 74: I think we still support this variant. Fang-Yu, can you confirm? http://gerrit.cloudera.org:8080/#/c/17469/1/docs/topics/impala_alter_table.xml@a322 PS1, Line 322: Same as above http://gerrit.cloudera.org:8080/#/c/17469/1/docs/topics/impala_alter_view.xml File docs/topics/impala_alter_view.xml: http://gerrit.cloudera.org:8080/#/c/17469/1/docs/topics/impala_alter_view.xml@a71 PS1, Line 71: I think we still support this variant. Fang-Yu, can you confirm? http://gerrit.cloudera.org:8080/#/c/17469/1/docs/topics/impala_authorization.xml File docs/topics/impala_authorization.xml: http://gerrit.cloudera.org:8080/#/c/17469/1/docs/topics/impala_authorization.xml@164 PS1, Line 164: before starting Impala cluster I think we can omit this. http://gerrit.cloudera.org:8080/#/c/17469/1/docs/topics/impala_authorization.xml@229 PS1, Line 229: fe/src/test/resources/ I don't think we should use this specific path. This is true for an Impala development environment, but it has little relationship to actual user deployments. http://gerrit.cloudera.org:8080/#/c/17469/1/docs/topics/impala_authorization.xml@306 PS1, Line 306: The following examples show how to set up authorization to deal with various scenarios : and how to grant privileges on objects to groups of users via roles, but note that you : could also grant privileges on objects to a user or a group directly without involving a : role. This is a very long sentence with a lot going on. Let's cut it down: "The following examples show how to set up authorization to grant privileges on objects to groups of users via roles." http://gerrit.cloudera.org:8080/#/c/17469/1/docs/topics/impala_grant.xml File docs/topics/impala_grant.xml: http://gerrit.cloudera.org:8080/#/c/17469/1/docs/topics/impala_grant.xml@101 PS1, Line 101: belonging to a group Nit: I don't think this addition gets us much. The original phrase was clear enough. http://gerrit.cloudera.org:8080/#/c/17469/1/docs/topics/impala_show.xml File docs/topics/impala_show.xml: http://gerrit.cloudera.org:8080/#/c/17469/1/docs/topics/impala_show.xml@38 PS1, Line 38: The following statements are supported in Impala through Ranger to : manage authorization. Two things here: 1. This is garbled. I'm assuming this is intended to be similar to the "The following statements are supported only when Impala uses Ranger to manage authorization." from before. 2. Where should this statement go? It doesn't apply to the non-authorization show statements, so I feel it should move down a bit. I guess the other question is whether this statement can just be removed completely. -- To view, visit http://gerrit.cloudera.org:8080/17469 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Id4c5e9aa4d060ceaa426908a444d280a5564749d Gerrit-Change-Number: 17469 Gerrit-PatchSet: 1 Gerrit-Owner: Shajini Thayasingh <sthayasi...@cloudera.com> Gerrit-Reviewer: Fang-Yu Rao <fangyu....@cloudera.com> Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com> Gerrit-Reviewer: Joe McDonnell <joemcdonn...@cloudera.com> Gerrit-Comment-Date: Tue, 18 May 2021 22:24:38 +0000 Gerrit-HasComments: Yes
