Aman Sinha has posted comments on this change. ( http://gerrit.cloudera.org:8080/17387 )
Change subject: IMPALA-10681: Improve inner join cardinality estimates ...................................................................... Patch Set 8: Code-Review+1 (1 comment) Carry forward +1 from Zoltan and Qifan. http://gerrit.cloudera.org:8080/#/c/17387/7/fe/src/main/java/org/apache/impala/planner/JoinNode.java File fe/src/main/java/org/apache/impala/planner/JoinNode.java: http://gerrit.cloudera.org:8080/#/c/17387/7/fe/src/main/java/org/apache/impala/planner/JoinNode.java@450 PS7, Line 450: getGenericJoinCardinali > nit. It is still better call this new method getGenericJoinCardinality(), Agreed. I changed it to getGenericJoinCardinality2() because the function signature's first parameter is a template type and Java does not allow 2 methods with same name only differing in the template type. It gives a compilation failure due to the 'Type Erasure' conflicts. -- To view, visit http://gerrit.cloudera.org:8080/17387 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I8aa9d3b8f3c4848b3e9414fe19ad7ad348d12ecc Gerrit-Change-Number: 17387 Gerrit-PatchSet: 8 Gerrit-Owner: Aman Sinha <[email protected]> Gerrit-Reviewer: Aman Sinha <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Qifan Chen <[email protected]> Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]> Gerrit-Comment-Date: Mon, 24 May 2021 17:42:17 +0000 Gerrit-HasComments: Yes
