Aman Sinha has posted comments on this change. ( http://gerrit.cloudera.org:8080/17521 )
Change subject: IMPALA-10700: Add query options to skip deleting stats ...................................................................... Patch Set 3: Code-Review+1 (1 comment) One comment about the tests. Code changes LGTM. I can upgrade to +2 once the test is fixed. http://gerrit.cloudera.org:8080/#/c/17521/3/testdata/workloads/functional-query/queries/QueryTest/truncate-table.test File testdata/workloads/functional-query/queries/QueryTest/truncate-table.test: http://gerrit.cloudera.org:8080/#/c/17521/3/testdata/workloads/functional-query/queries/QueryTest/truncate-table.test@308 PS3, Line 308: stats t1; This seems to be the wrong table..should be t4. -- To view, visit http://gerrit.cloudera.org:8080/17521 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I9400c3586b4bdf46d9b4056ea1023aabae8cc519 Gerrit-Change-Number: 17521 Gerrit-PatchSet: 3 Gerrit-Owner: Vihang Karajgaonkar <[email protected]> Gerrit-Reviewer: Aman Sinha <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Reviewer: Vihang Karajgaonkar <[email protected]> Gerrit-Comment-Date: Thu, 27 May 2021 21:25:58 +0000 Gerrit-HasComments: Yes
