Impala Public Jenkins has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/17530 )

Change subject: IMPALA-5569: Add statement ALTER TABLE UNSET 
TBLPROPERTIES/SERDEPROPERTIES
......................................................................


Patch Set 1:

(6 comments)

http://gerrit.cloudera.org:8080/#/c/17530/1/fe/src/main/java/org/apache/impala/analysis/AlterTableUnSetTblProperties.java
File 
fe/src/main/java/org/apache/impala/analysis/AlterTableUnSetTblProperties.java:

http://gerrit.cloudera.org:8080/#/c/17530/1/fe/src/main/java/org/apache/impala/analysis/AlterTableUnSetTblProperties.java@48
PS1, Line 48:   public AlterTableUnSetTblProperties(TableName tableName, 
PartitionSet partitionSet, boolean ifExists,
line too long (103 > 90)


http://gerrit.cloudera.org:8080/#/c/17530/1/fe/src/main/java/org/apache/impala/analysis/AlterTableUnSetTblProperties.java@49
PS1, Line 49:                                       TTablePropertyType 
targetProperty, List<String> tblPropertyKeys) {
line too long (104 > 90)


http://gerrit.cloudera.org:8080/#/c/17530/1/fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java
File fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java:

http://gerrit.cloudera.org:8080/#/c/17530/1/fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java@3748
PS1, Line 3748:                                           
TAlterTableUnSetTblPropertiesParams params, Reference<Long> 
numUpdatedPartitions)
line too long (123 > 90)


http://gerrit.cloudera.org:8080/#/c/17530/1/fe/src/test/java/org/apache/impala/analysis/AnalyzeDDLTest.java
File fe/src/test/java/org/apache/impala/analysis/AnalyzeDDLTest.java:

http://gerrit.cloudera.org:8080/#/c/17530/1/fe/src/test/java/org/apache/impala/analysis/AnalyzeDDLTest.java@806
PS1, Line 806:               "Property key length must be <= " + 
MetaStoreUtil.MAX_PROPERTY_KEY_LENGTH + ": "
line too long (94 > 90)


http://gerrit.cloudera.org:8080/#/c/17530/1/fe/src/test/java/org/apache/impala/analysis/AnalyzeDDLTest.java@821
PS1, Line 821:               "Property key length must be <= " + 
MetaStoreUtil.MAX_PROPERTY_KEY_LENGTH + ": "
line too long (94 > 90)


http://gerrit.cloudera.org:8080/#/c/17530/1/fe/src/test/java/org/apache/impala/analysis/AnalyzeDDLTest.java@836
PS1, Line 836:               "Changing the 'storage_handler' table property is 
not supported to protect " +
line too long (92 > 90)



--
To view, visit http://gerrit.cloudera.org:8080/17530
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ife4f6561dcdcd20c76eb299c6661c778e342509d
Gerrit-Change-Number: 17530
Gerrit-PatchSet: 1
Gerrit-Owner: Amogh Margoor <[email protected]>
Gerrit-Reviewer: Impala Public Jenkins <[email protected]>
Gerrit-Comment-Date: Wed, 02 Jun 2021 00:07:02 +0000
Gerrit-HasComments: Yes

Reply via email to