Zoltan Borok-Nagy has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/17542 )

Change subject: IMPALA-10187: Event processing fails on multiple events + DROP 
TABLE
......................................................................


Patch Set 2:

(3 comments)

Thanks for the comments, Vihang!

http://gerrit.cloudera.org:8080/#/c/17542/1/fe/src/main/java/org/apache/impala/catalog/CatalogServiceCatalog.java
File fe/src/main/java/org/apache/impala/catalog/CatalogServiceCatalog.java:

http://gerrit.cloudera.org:8080/#/c/17542/1/fe/src/main/java/org/apache/impala/catalog/CatalogServiceCatalog.java@2740
PS1, Line 2740: reloadTableIfExists
> I discussed with Zoltan offline and we agreed that since https://gerrit.clo
Done


http://gerrit.cloudera.org:8080/#/c/17542/1/tests/custom_cluster/test_event_processing.py
File tests/custom_cluster/test_event_processing.py:

http://gerrit.cloudera.org:8080/#/c/17542/1/tests/custom_cluster/test_event_processing.py@220
PS1, Line 220: es
> Setting table directory to /tmp can lead to flakiness if the drop table sta
Thanks for pointing this out. I've switched to use ALTER TABLE SET 
TBLPROPERTIES which might be the safest thing to to.


http://gerrit.cloudera.org:8080/#/c/17542/1/tests/custom_cluster/test_event_processing.py@224
PS1, Line 224: assert EventProcessorUtils.get_event_processor_status() == 
"ACTIVE"
             :
             :   def __run_event_based_replication_tests(self, 
transactional=True):
             :     """Hive Replication relies on the insert events generated on 
the tables.
             :     This test issues some basic replication commands from Hive 
and makes sure
             :     that the replicated table has correct data."""
             :     TBLPROPERTIES = 
self.__get_transactional_tblproperties(transactional)
             :     source_db = self.__g
> Or you can simply do the following
Ah, nice. Done.



--
To view, visit http://gerrit.cloudera.org:8080/17542
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I2bd72247293d830063f66eecf9e4ba69a439a605
Gerrit-Change-Number: 17542
Gerrit-PatchSet: 2
Gerrit-Owner: Zoltan Borok-Nagy <[email protected]>
Gerrit-Reviewer: Impala Public Jenkins <[email protected]>
Gerrit-Reviewer: Vihang Karajgaonkar <[email protected]>
Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]>
Gerrit-Comment-Date: Mon, 07 Jun 2021 08:55:10 +0000
Gerrit-HasComments: Yes

Reply via email to