Sourabh Goyal has posted comments on this change. ( http://gerrit.cloudera.org:8080/17298 )
Change subject: IMPALA-10648: Invalidate catalogd table metadata cache for HMS DDL apis ...................................................................... Patch Set 23: (1 comment) http://gerrit.cloudera.org:8080/#/c/17298/23/fe/src/main/java/org/apache/impala/catalog/metastore/MetastoreServiceHandler.java File fe/src/main/java/org/apache/impala/catalog/metastore/MetastoreServiceHandler.java: http://gerrit.cloudera.org:8080/#/c/17298/23/fe/src/main/java/org/apache/impala/catalog/metastore/MetastoreServiceHandler.java@3024 PS23, Line 3024: LOG.debug("Couldn't rename " + tableInfo); > Does this need to throw an error? Good catch! Yes we should throw an error here? Will MetaException be fine? I have a follow up patch planned for drop table issue. I can address this comment in that patch -- To view, visit http://gerrit.cloudera.org:8080/17298 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Idb9cc22ebfb51948433e4d57f4705ce201acaf98 Gerrit-Change-Number: 17298 Gerrit-PatchSet: 23 Gerrit-Owner: Sourabh Goyal <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Reviewer: Sourabh Goyal <[email protected]> Gerrit-Reviewer: Vihang Karajgaonkar <[email protected]> Gerrit-Comment-Date: Wed, 09 Jun 2021 17:38:56 +0000 Gerrit-HasComments: Yes
