Qifan Chen has posted comments on this change. ( http://gerrit.cloudera.org:8080/17553 )
Change subject: IMPALA-10557: Support Kudu's multi-row transaction ...................................................................... Patch Set 7: Code-Review+1 (3 comments) Looks good and thanks for the rework! http://gerrit.cloudera.org:8080/#/c/17553/5/be/src/exec/kudu-scan-node-base.h File be/src/exec/kudu-scan-node-base.h: http://gerrit.cloudera.org:8080/#/c/17553/5/be/src/exec/kudu-scan-node-base.h@102 PS5, Line 102: kudu::client::KuduClient* kudu_client() { return client_.get(); } > This function is called when calling Kudu API KuduScanToken::DeserializeInt Sorry I did not make it clear in the comment. I meant to make the member function const. kudu::client::KuduClient* kudu_client() const { return client_.get(); } http://gerrit.cloudera.org:8080/#/c/17553/5/be/src/service/client-request-state.h File be/src/service/client-request-state.h: http://gerrit.cloudera.org:8080/#/c/17553/5/be/src/service/client-request-state.h@768 PS5, Line 768: /// Aborts the Kudu transaction of this client request. > This function write error log if it's failed. Caller cannot take additional Done http://gerrit.cloudera.org:8080/#/c/17553/5/be/src/service/client-request-state.h@772 PS5, Line 772: void CommitKuduTransaction(); > This function write error log if it's failed. Caller cannot take additional Done -- To view, visit http://gerrit.cloudera.org:8080/17553 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I876ada48991afdff5d61b5d6a0417571aba7cb34 Gerrit-Change-Number: 17553 Gerrit-PatchSet: 7 Gerrit-Owner: Wenzhe Zhou <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Bikramjeet Vig <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Qifan Chen <[email protected]> Gerrit-Reviewer: Wenzhe Zhou <[email protected]> Gerrit-Comment-Date: Thu, 10 Jun 2021 20:03:43 +0000 Gerrit-HasComments: Yes
