Abhishek Rawat has posted comments on this change. ( http://gerrit.cloudera.org:8080/17572 )
Change subject: IMPALA-10636: Add testcases for abnormal cases of spilling to a remote filesystem ...................................................................... Patch Set 1: Code-Review+1 (1 comment) LGTM, Just had one comment about making a const variable non-const. http://gerrit.cloudera.org:8080/#/c/17572/1/be/src/runtime/io/disk-file.h File be/src/runtime/io/disk-file.h: http://gerrit.cloudera.org:8080/#/c/17572/1/be/src/runtime/io/disk-file.h@154 PS1, Line 154: Is there no other way to specify an invalid path? Is the issue that we will fail too early for the testcase, if we specify an invalid path in the constructor? -- To view, visit http://gerrit.cloudera.org:8080/17572 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I600f93d67ba2267c14d179822056a24bedca31ef Gerrit-Change-Number: 17572 Gerrit-PatchSet: 1 Gerrit-Owner: Yida Wu <[email protected]> Gerrit-Reviewer: Abhishek Rawat <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Comment-Date: Fri, 11 Jun 2021 21:44:48 +0000 Gerrit-HasComments: Yes
