Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/17593 )
Change subject: IMPALA-10166 (part 2): Enable DROP and CHANGE column ...................................................................... Patch Set 1: Code-Review+1 (1 comment) http://gerrit.cloudera.org:8080/#/c/17593/1/testdata/workloads/functional-query/queries/QueryTest/iceberg-alter.test File testdata/workloads/functional-query/queries/QueryTest/iceberg-alter.test: http://gerrit.cloudera.org:8080/#/c/17593/1/testdata/workloads/functional-query/queries/QueryTest/iceberg-alter.test@172 PS1, Line 172: float -> double is allowed by Iceberg. Can you add some tests for other types? According to https://github.com/apache/impala/blob/master/fe/src/main/java/org/apache/impala/service/IcebergCatalogOpExecutor.java#L119 only 3 type conversions are supported. I am particularly curious about the decimal -> decimal change, which looks hard to implement correctly. -- To view, visit http://gerrit.cloudera.org:8080/17593 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I9b0d1a55bf0ed718724a69b51392ed53680ffa90 Gerrit-Change-Number: 17593 Gerrit-PatchSet: 1 Gerrit-Owner: Zoltan Borok-Nagy <[email protected]> Gerrit-Reviewer: Attila Jeges <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: wangsheng <[email protected]> Gerrit-Comment-Date: Tue, 15 Jun 2021 06:18:40 +0000 Gerrit-HasComments: Yes
