Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/17596 )
Change subject: IMPALA-10742: Fix DCHECK in CreateColIdx2EqConjunctMap ...................................................................... Patch Set 4: (3 comments) http://gerrit.cloudera.org:8080/#/c/17596/3//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/17596/3//COMMIT_MSG@9 PS3, Line 9: the right side was not > nit: could you elaborate a little? Done http://gerrit.cloudera.org:8080/#/c/17596/3/be/src/exec/parquet/hdfs-parquet-scanner.cc File be/src/exec/parquet/hdfs-parquet-scanner.cc: http://gerrit.cloudera.org:8080/#/c/17596/3/be/src/exec/parquet/hdfs-parquet-scanner.cc@1663 PS3, Line 1663: == > Shouldn't it be ==? ouch, thanks ... http://gerrit.cloudera.org:8080/#/c/17596/3/tests/query_test/test_exprs.py File tests/query_test/test_exprs.py: http://gerrit.cloudera.org:8080/#/c/17596/3/tests/query_test/test_exprs.py@42 PS3, Line 42: > nit: no need for \ Done -- To view, visit http://gerrit.cloudera.org:8080/17596 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I1ef97d829e6c3792aade9c61c4aee0d91cd0064b Gerrit-Change-Number: 17596 Gerrit-PatchSet: 4 Gerrit-Owner: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Daniel Becker <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]> Gerrit-Comment-Date: Tue, 15 Jun 2021 12:58:30 +0000 Gerrit-HasComments: Yes
