Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/17553 )
Change subject: IMPALA-10557: Support Kudu's multi-row transaction ...................................................................... Patch Set 17: (4 comments) http://gerrit.cloudera.org:8080/#/c/17553/14/tests/custom_cluster/test_kudu.py File tests/custom_cluster/test_kudu.py: http://gerrit.cloudera.org:8080/#/c/17553/14/tests/custom_cluster/test_kudu.py@388 PS14, Line 388: # Disable Kudu transactions and insert rows to the Kudu table. Should get same : # results as transaction enabled. : self.execute_query("set ENABLE_KUDU_TRANSACTION=false") : self.execute_query(self._insert_3_rows_query.format(table_name)) : cursor.execute(self._row_num_query.format(table_name)) : assert cursor.fetchall() == [(3,)] : self.execute_query(self._insert_select_query.format(table_name)) : cursor.execute(self._row_num_query.format(table_name)) : assert cursor.fetchall() == [(103,)] : : @pytest.mark.execute_serially > I will move these tests to a separate test case. Thank you for updating this! http://gerrit.cloudera.org:8080/#/c/17553/17/tests/custom_cluster/test_kudu.py File tests/custom_cluster/test_kudu.py: http://gerrit.cloudera.org:8080/#/c/17553/17/tests/custom_cluster/test_kudu.py@386 PS17, Line 386: self.execute_query(self._delete_query.format(table_name)) Why don't we need to move this below L390? Wouldn't the delete queries fail as a part of a transaction? http://gerrit.cloudera.org:8080/#/c/17553/17/tests/custom_cluster/test_kudu.py@417 PS17, Line 417: self.execute_query(self._update_query.format(table_name)) : self.execute_query(self._upsert_query.format(table_name)) : self.execute_query(self._delete_query.format(table_name)) Can we have three separate try/catches? Otherwise we'll just fail at the first query and skip testing the other two, right? http://gerrit.cloudera.org:8080/#/c/17553/17/tests/custom_cluster/test_kudu.py@422 PS17, Line 422: assert "Not implemented" in str(e) nit: consider re-checking the number of rows after failing the above operations? -- To view, visit http://gerrit.cloudera.org:8080/17553 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I876ada48991afdff5d61b5d6a0417571aba7cb34 Gerrit-Change-Number: 17553 Gerrit-PatchSet: 17 Gerrit-Owner: Wenzhe Zhou <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Bikramjeet Vig <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Qifan Chen <[email protected]> Gerrit-Reviewer: Wenzhe Zhou <[email protected]> Gerrit-Comment-Date: Tue, 15 Jun 2021 21:30:21 +0000 Gerrit-HasComments: Yes
