Wenzhe Zhou has posted comments on this change. ( http://gerrit.cloudera.org:8080/17553 )
Change subject: IMPALA-10557: Support Kudu's multi-row transaction ...................................................................... Patch Set 19: (2 comments) http://gerrit.cloudera.org:8080/#/c/17553/19/fe/src/main/java/org/apache/impala/service/Frontend.java File fe/src/main/java/org/apache/impala/service/Frontend.java: http://gerrit.cloudera.org:8080/#/c/17553/19/fe/src/main/java/org/apache/impala/service/Frontend.java@1722 PS19, Line 1722: don't > nit: "doesn't" or "does not", same below. The code were removed. http://gerrit.cloudera.org:8080/#/c/17553/19/fe/src/main/java/org/apache/impala/service/Frontend.java@1818 PS19, Line 1818: if (queryOptions.isEnable_kudu_transaction()) { : // Kudu don't support transaction for DELETE/UPDATE statements now. : if (analysisResult.isUpdateStmt() : && analysisResult.getUpdateStmt().isTargetTableKuduTable()) { : throw new TransactionException( : "Kudu don't support transaction for UPDATE statement."); : } else if (analysisResult.isDeleteStmt() : && analysisResult.getDeleteStmt().isTargetTableKuduTable()) { : throw new TransactionException( : "Kudu don't support transaction for DELETE statement."); : } : } > Just curious -- today Kudu will return an error if trying to update or dele Changed code to open transaction for delete/update/upsert. Also updated commit message and test cases. -- To view, visit http://gerrit.cloudera.org:8080/17553 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I876ada48991afdff5d61b5d6a0417571aba7cb34 Gerrit-Change-Number: 17553 Gerrit-PatchSet: 19 Gerrit-Owner: Wenzhe Zhou <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Andrew Wong <[email protected]> Gerrit-Reviewer: Bikramjeet Vig <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Qifan Chen <[email protected]> Gerrit-Reviewer: Wenzhe Zhou <[email protected]> Gerrit-Comment-Date: Thu, 17 Jun 2021 01:17:45 +0000 Gerrit-HasComments: Yes
