wangsheng has posted comments on this change. ( http://gerrit.cloudera.org:8080/17575 )
Change subject: IMPALA-10732: Use consistent DDL for specifying Iceberg partitions ...................................................................... Patch Set 3: (4 comments) Sorry for my late reply, Zoltan. Thanks for this feature, it's quite important to keep consistent syntax with other engines. Here is some of my opinions. http://gerrit.cloudera.org:8080/#/c/17575/3//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/17575/3//COMMIT_MSG@35 PS3, Line 35: We might later consider making 'SPEC' optional. I think making 'SPEC' optional maybe confused users. It's better to removed this key word or keeping it as necessary in create statement. How do you think? http://gerrit.cloudera.org:8080/#/c/17575/3/fe/src/main/java/org/apache/impala/analysis/IcebergPartitionTransform.java File fe/src/main/java/org/apache/impala/analysis/IcebergPartitionTransform.java: http://gerrit.cloudera.org:8080/#/c/17575/3/fe/src/main/java/org/apache/impala/analysis/IcebergPartitionTransform.java@97 PS3, Line 97: builder.append(transformType_.toString() + "("); Maybe this is better: builder.append(transformType_.toString()).append("("); http://gerrit.cloudera.org:8080/#/c/17575/3/fe/src/main/java/org/apache/impala/analysis/IcebergPartitionTransform.java@99 PS3, Line 99: builder.append(transformParam_.toString() + ", "); Same as above http://gerrit.cloudera.org:8080/#/c/17575/3/fe/src/main/java/org/apache/impala/util/IcebergUtil.java File fe/src/main/java/org/apache/impala/util/IcebergUtil.java: http://gerrit.cloudera.org:8080/#/c/17575/3/fe/src/main/java/org/apache/impala/util/IcebergUtil.java@297 PS3, Line 297: case "HOUR": case "HOURS": return TIcebergPartitionTransformType.HOUR; : case "DAY": case "DAYS": return TIcebergPartitionTransformType.DAY; : case "MONTH": case "MONTHS": return TIcebergPartitionTransformType.MONTH; : case "YEAR": case "YEARS": return TIcebergPartitionTransformType.YEAR; I see that both Hive and Spark use HOURS/DAYS/MONTHS/YEARS in your comment example, maybe we do not need to support HOUR/DAY/MONTH/YEAR. -- To view, visit http://gerrit.cloudera.org:8080/17575 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ib72ae445fd68fb0ab75d87b34779dbab922bbc62 Gerrit-Change-Number: 17575 Gerrit-PatchSet: 3 Gerrit-Owner: Zoltan Borok-Nagy <[email protected]> Gerrit-Reviewer: Attila Jeges <[email protected]> Gerrit-Reviewer: Gabor Kaszab <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: wangsheng <[email protected]> Gerrit-Comment-Date: Thu, 17 Jun 2021 08:16:43 +0000 Gerrit-HasComments: Yes
