Aman Sinha has posted comments on this change. ( http://gerrit.cloudera.org:8080/17614 )
Change subject: IMPALA-10760: Added accessor methods to Function classes ...................................................................... Patch Set 2: Code-Review+1 (2 comments) couple of nits. http://gerrit.cloudera.org:8080/#/c/17614/2//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/17614/2//COMMIT_MSG@9 PS2, Line 9: functions nit: these are symbol strings rather than functions ? http://gerrit.cloudera.org:8080/#/c/17614/2//COMMIT_MSG@10 PS2, Line 10: class nit: might want to say Function classes (or Aggregate/Scalar function classes). -- To view, visit http://gerrit.cloudera.org:8080/17614 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I4b42c1a9cbca7f421cf8cbcf79890eb4a5ac3582 Gerrit-Change-Number: 17614 Gerrit-PatchSet: 2 Gerrit-Owner: Steve Carlin <[email protected]> Gerrit-Reviewer: Aman Sinha <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Comment-Date: Tue, 22 Jun 2021 02:47:56 +0000 Gerrit-HasComments: Yes
