Zoltan Borok-Nagy has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/17593 )
Change subject: IMPALA-10166 (part 2): Enable DROP and CHANGE column ...................................................................... IMPALA-10166 (part 2): Enable DROP and CHANGE column IMPALA-10166 (part 1) already added the necessary code for DROP and CHANGE COLUMN, but disabled those stmts because to correctly support schema evolution we had to wait for column resolution by Iceberg field id. Since then IMPALA-10361 and IMPALA-10485 added support for field-id based column resolution for Parquet and ORC as well. Hence this patch enables DROP and CHANGE column ALTER TABLE statements. We still disallow REPLACE COLUMNS because it doesn't really make sense for Iceberg tables as it basically makes all existing data inaccessible. Changing DECIMAL columns are still disabled due to IMPALA-7087. Testing: * added e2e tests Change-Id: I9b0d1a55bf0ed718724a69b51392ed53680ffa90 Reviewed-on: http://gerrit.cloudera.org:8080/17593 Reviewed-by: Impala Public Jenkins <[email protected]> Tested-by: Zoltan Borok-Nagy <[email protected]> --- M fe/src/main/java/org/apache/impala/analysis/AlterTableReplaceColsStmt.java M fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java M fe/src/main/java/org/apache/impala/service/IcebergCatalogOpExecutor.java M testdata/workloads/functional-query/queries/QueryTest/iceberg-alter.test M testdata/workloads/functional-query/queries/QueryTest/iceberg-negative.test 5 files changed, 156 insertions(+), 38 deletions(-) Approvals: Impala Public Jenkins: Looks good to me, approved Zoltan Borok-Nagy: Verified -- To view, visit http://gerrit.cloudera.org:8080/17593 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: I9b0d1a55bf0ed718724a69b51392ed53680ffa90 Gerrit-Change-Number: 17593 Gerrit-PatchSet: 7 Gerrit-Owner: Zoltan Borok-Nagy <[email protected]> Gerrit-Reviewer: Attila Jeges <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]> Gerrit-Reviewer: wangsheng <[email protected]>
