Impala Public Jenkins has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/17308 )

Change subject: IMPALA-10502: Handle CREATE/DROP events correctly
......................................................................


Patch Set 11:

(4 comments)

http://gerrit.cloudera.org:8080/#/c/17308/11/fe/src/main/java/org/apache/impala/catalog/HdfsTable.java
File fe/src/main/java/org/apache/impala/catalog/HdfsTable.java:

http://gerrit.cloudera.org:8080/#/c/17308/11/fe/src/main/java/org/apache/impala/catalog/HdfsTable.java@1374
PS11, Line 1374:             loadPartitionFileMetadata, partitionsToUpdate, 
partitionToEventId, debugAction)
line too long (91 > 90)


http://gerrit.cloudera.org:8080/#/c/17308/11/fe/src/main/java/org/apache/impala/catalog/HdfsTable.java@1803
PS11, Line 1803:       @Nullable Map<String, Long> partitionToEventId, 
IMetaStoreClient client) throws Exception {
line too long (97 > 90)


http://gerrit.cloudera.org:8080/#/c/17308/11/tests/custom_cluster/test_event_processing.py
File tests/custom_cluster/test_event_processing.py:

http://gerrit.cloudera.org:8080/#/c/17308/11/tests/custom_cluster/test_event_processing.py@326
PS11, Line 326:
flake8: W293 blank line contains whitespace


http://gerrit.cloudera.org:8080/#/c/17308/11/tests/custom_cluster/test_event_processing.py@326
PS11, Line 326:
line has trailing whitespace



--
To view, visit http://gerrit.cloudera.org:8080/17308
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia2c5e96b48abac015240f20295b3ec3b1d71f24a
Gerrit-Change-Number: 17308
Gerrit-PatchSet: 11
Gerrit-Owner: Vihang Karajgaonkar <[email protected]>
Gerrit-Reviewer: Impala Public Jenkins <[email protected]>
Gerrit-Reviewer: Quanlong Huang <[email protected]>
Gerrit-Reviewer: Sourabh Goyal <[email protected]>
Gerrit-Reviewer: Vihang Karajgaonkar <[email protected]>
Gerrit-Comment-Date: Tue, 22 Jun 2021 16:48:30 +0000
Gerrit-HasComments: Yes

Reply via email to