Impala Public Jenkins has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/17580 )

Change subject: IMPALA-2019(Part-2): Provide UTF-8 support in instr() and 
locate()
......................................................................


Patch Set 4:

(2 comments)

http://gerrit.cloudera.org:8080/#/c/17580/4/be/src/util/string-util-test.cc
File be/src/util/string-util-test.cc:

http://gerrit.cloudera.org:8080/#/c/17580/4/be/src/util/string-util-test.cc@150
PS4, Line 150:   // Here we just need 4 characters, i.e. "李小龙 " in byte length 
10. Set 'str_len' to 10
line too long (93 > 90)


http://gerrit.cloudera.org:8080/#/c/17580/4/be/src/util/string-util-test.cc@199
PS4, Line 199:   // Here we just need 4 characters, i.e. "李小龙 " in byte length 
10. Set 'str_len' to 10
line too long (93 > 90)



--
To view, visit http://gerrit.cloudera.org:8080/17580
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic13c3d04649c1aea56c1aaa464799b5e4674f662
Gerrit-Change-Number: 17580
Gerrit-PatchSet: 4
Gerrit-Owner: Quanlong Huang <[email protected]>
Gerrit-Reviewer: Impala Public Jenkins <[email protected]>
Gerrit-Reviewer: Qifan Chen <[email protected]>
Gerrit-Reviewer: Quanlong Huang <[email protected]>
Gerrit-Comment-Date: Thu, 24 Jun 2021 07:11:45 +0000
Gerrit-HasComments: Yes

Reply via email to