Impala Public Jenkins has submitted this change and it was merged. ( 
http://gerrit.cloudera.org:8080/17629 )

Change subject: IMPALA-10765: Allow firing INSERT events with empty results
......................................................................

IMPALA-10765: Allow firing INSERT events with empty results

When INSERT or the INSERT part of a CTAS statement produces empty
results, catalogd will hit a Precondition check in createInsertEvents()
if the statement is not specified with OVERWRITE. This patch removes the
checks to relax the restriction. This is consistent with Hive since Hive
also fires insert events on empty insert results.

Previously when event processor is disabled, we won't generate INSERT
events. This is inconsistent with other DDL events which will always be
generated by Hive. This patch removes the check on event processor's
status. So firing INSERT events is independent to the event processor.
This fixes IMPALA-10744.

Tests
 - Add e2e test

Change-Id: Id708f38302b37d7e09435e7b8b0c9fc071659606
Reviewed-on: http://gerrit.cloudera.org:8080/17629
Reviewed-by: Impala Public Jenkins <[email protected]>
Tested-by: Impala Public Jenkins <[email protected]>
---
M fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java
M tests/custom_cluster/test_event_processing.py
2 files changed, 36 insertions(+), 6 deletions(-)

Approvals:
  Impala Public Jenkins: Looks good to me, approved; Verified

--
To view, visit http://gerrit.cloudera.org:8080/17629
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Id708f38302b37d7e09435e7b8b0c9fc071659606
Gerrit-Change-Number: 17629
Gerrit-PatchSet: 5
Gerrit-Owner: Quanlong Huang <[email protected]>
Gerrit-Reviewer: Csaba Ringhofer <[email protected]>
Gerrit-Reviewer: Impala Public Jenkins <[email protected]>
Gerrit-Reviewer: Quanlong Huang <[email protected]>
Gerrit-Reviewer: Vihang Karajgaonkar <[email protected]>
Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]>

Reply via email to