Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/17635 )
Change subject: [WIP] IMPALA-10763: Min/max filters should be enabled on Z-order sorted columns ...................................................................... Patch Set 2: (2 comments) Good to see the enhancement :) http://gerrit.cloudera.org:8080/#/c/17635/2/fe/src/main/java/org/apache/impala/planner/HdfsScanNode.java File fe/src/main/java/org/apache/impala/planner/HdfsScanNode.java: http://gerrit.cloudera.org:8080/#/c/17635/2/fe/src/main/java/org/apache/impala/planner/HdfsScanNode.java@752 PS2, Line 752: table != null nit: this can be removed since null can't satify "table instanceof FeFsTable" http://gerrit.cloudera.org:8080/#/c/17635/2/fe/src/main/java/org/apache/impala/planner/HdfsScanNode.java@762 PS2, Line 762: // Must be Z-order. Allow it. : Preconditions.checkState(sortOrder == TSortingOrder.ZORDER); Should we check whether the column is in the "sort.columns"? Z-order doesn't sort on all columns. -- To view, visit http://gerrit.cloudera.org:8080/17635 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I2a528ffbd0e333721ef38b4be7d4ddcdbf188adf Gerrit-Change-Number: 17635 Gerrit-PatchSet: 2 Gerrit-Owner: Qifan Chen <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Comment-Date: Fri, 25 Jun 2021 08:28:15 +0000 Gerrit-HasComments: Yes
