Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/17640 )
Change subject: IMPALA-10436: Require lower privilege for external Kudu table creation ...................................................................... Patch Set 1: Code-Review+1 (2 comments) The changes make sense to me. Thanks for the work! http://gerrit.cloudera.org:8080/#/c/17640/1//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/17640/1//COMMIT_MSG@16 PS1, Line 16: Now that Kudu supports authorization Is there a way to know whether the underlying kudu cluster has enabled authorization? http://gerrit.cloudera.org:8080/#/c/17640/1/fe/src/main/java/org/apache/impala/analysis/CreateTableStmt.java File fe/src/main/java/org/apache/impala/analysis/CreateTableStmt.java: http://gerrit.cloudera.org:8080/#/c/17640/1/fe/src/main/java/org/apache/impala/analysis/CreateTableStmt.java@335 PS1, Line 335: // Today there is no comprehensive way of enforcing a Ranger authorization policy : // against tables stored in Kudu. This is why only users with ALL privileges on : // SERVER may create external Kudu tables or set the master addresses. I think we need to update these as well since now kudu supports Ranger authorization. -- To view, visit http://gerrit.cloudera.org:8080/17640 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I7936e1d8c48696169f7ad7ad92abe44a26eea3c4 Gerrit-Change-Number: 17640 Gerrit-PatchSet: 1 Gerrit-Owner: Fang-Yu Rao <[email protected]> Gerrit-Reviewer: Aman Sinha <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Fang-Yu Rao <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Comment-Date: Tue, 29 Jun 2021 07:33:05 +0000 Gerrit-HasComments: Yes
