Fang-Yu Rao has posted comments on this change. ( http://gerrit.cloudera.org:8080/17386 )
Change subject: IMPALA-10694: Improve the error handling of setup-ranger ...................................................................... Patch Set 4: (1 comment) Thanks Csaba and Quanlong for the suggestion and sorry for the late response. Please let me know if there is any other comment or suggestion. Thank you very much for the help! http://gerrit.cloudera.org:8080/#/c/17386/2/testdata/bin/create-load-data.sh File testdata/bin/create-load-data.sh: http://gerrit.cloudera.org:8080/#/c/17386/2/testdata/bin/create-load-data.sh@344 PS2, Line 344: export GROUP_ID_OWNER : : GROUP_ID_NON_OWNER=$(wget -qO - --auth-no-challenge --user=admin \ : --password=admin --post-file="${RANGER_SETUP_DIR}/impala_group_non_owner.json" \ : > +1 on this direction Thanks Csaba and Quanlong! Yes. You are correct. "res=$?" won't be executed if there was an error during the execution of the immediately preceding wget. I missed this because I forgot to add "set -e" as done in create-load-data.sh when I copied the contents of setup-ranger to a separate file to test my patch. And I agree with you, it would be sufficient to just separate the assignment and the export of the environment variables to fix the issue. -- To view, visit http://gerrit.cloudera.org:8080/17386 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I45605d1a7441b734cf80249626638cde3adce28b Gerrit-Change-Number: 17386 Gerrit-PatchSet: 4 Gerrit-Owner: Fang-Yu Rao <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Fang-Yu Rao <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Comment-Date: Tue, 29 Jun 2021 19:01:25 +0000 Gerrit-HasComments: Yes
