Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/17642 )
Change subject: IMPALA-10774: Collect the output when starting Hive Metastore or HiveServer2 ...................................................................... Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/17642/1/testdata/bin/run-hive-server.sh File testdata/bin/run-hive-server.sh: http://gerrit.cloudera.org:8080/#/c/17642/1/testdata/bin/run-hive-server.sh@135 PS1, Line 135: --service metastore -p $HIVE_METASTORE_PORT >> ${LOGDIR}/hive-metastore.out \ : 2>> ${LOGDIR}/hive-metastore.err 2>&1 & Most of these outputs don't have associated timestamps. I can only see one line has timestamp: 2021-06-25 18:14:12: Starting Hive Metastore Server I think it'd be better to keep them in the same file (i.e. hive-metastore.out) so we can match them. So I prefer to removing "2>> ${LOGDIR}/hive-metastore.err". BTW, "2>&1" seems to conflicts with "2>> ${LOGDIR}/hive-metastore.err". http://gerrit.cloudera.org:8080/#/c/17642/1/testdata/bin/run-hive-server.sh@153 PS1, Line 153: 2>> ${LOGDIR}/hive-server2.err 2>&1 & Same comment as above. -- To view, visit http://gerrit.cloudera.org:8080/17642 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I2efdbcf886e2d32ccf8c7eef038360884e44f216 Gerrit-Change-Number: 17642 Gerrit-PatchSet: 1 Gerrit-Owner: Fang-Yu Rao <[email protected]> Gerrit-Reviewer: Aman Sinha <[email protected]> Gerrit-Reviewer: Fang-Yu Rao <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Reviewer: Vihang Karajgaonkar <[email protected]> Gerrit-Comment-Date: Wed, 30 Jun 2021 01:39:23 +0000 Gerrit-HasComments: Yes
