Steve Carlin has posted comments on this change. ( http://gerrit.cloudera.org:8080/17660 )
Change subject: IMPALA-10778: Allow impala-shell to connect directly to HS2 ...................................................................... Patch Set 1: (6 comments) http://gerrit.cloudera.org:8080/#/c/17660/1/shell/impala_client.py File shell/impala_client.py: http://gerrit.cloudera.org:8080/#/c/17660/1/shell/impala_client.py@1072 PS1, Line 1072: class StrictHS2Client(ImpalaHS2Client): > flake8: E302 expected 2 blank lines, found 1 Done http://gerrit.cloudera.org:8080/#/c/17660/1/shell/impala_shell.py File shell/impala_shell.py: http://gerrit.cloudera.org:8080/#/c/17660/1/shell/impala_shell.py@914 PS1, Line 914: \ > flake8: E502 the backslash is redundant between brackets Done http://gerrit.cloudera.org:8080/#/c/17660/1/tests/common/test_dimensions.py File tests/common/test_dimensions.py: http://gerrit.cloudera.org:8080/#/c/17660/1/tests/common/test_dimensions.py@131 PS1, Line 131: def create_client_protocol_strict_dimension(): > flake8: E302 expected 2 blank lines, found 1 Done http://gerrit.cloudera.org:8080/#/c/17660/1/tests/common/test_dimensions.py@134 PS1, Line 134: def create_client_protocol_no_strict_dimension(): > flake8: E302 expected 2 blank lines, found 1 Done http://gerrit.cloudera.org:8080/#/c/17660/1/tests/shell/test_shell_commandline.py File tests/shell/test_shell_commandline.py: http://gerrit.cloudera.org:8080/#/c/17660/1/tests/shell/test_shell_commandline.py@277 PS1, Line 277: > flake8: E241 multiple spaces after ',' Done http://gerrit.cloudera.org:8080/#/c/17660/1/tests/shell/test_shell_commandline.py@615 PS1, Line 615: > line has trailing whitespace Done -- To view, visit http://gerrit.cloudera.org:8080/17660 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I674a45640a4a7b3c9a577830dbc7b16a89865a9e Gerrit-Change-Number: 17660 Gerrit-PatchSet: 1 Gerrit-Owner: Steve Carlin <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Steve Carlin <[email protected]> Gerrit-Comment-Date: Wed, 07 Jul 2021 23:07:23 +0000 Gerrit-HasComments: Yes
